elementary / elementary/icons

inkscape --export-plain-svg is bloating your diffs

Open
#470 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
Meson
Stars
594
Forks
83
Avg merge
23h 39m
Merged PRs (30d)
11

Description

https://github.com/elementary/icons/blob/d9014b6e170673aeba6e6b4659d7107ef905ebef/pre-commit#L11

When you run inkscape as above it reverses the order of attributes on some, and possibly every element in the file. This means git/diff thinks the whole file is completely different. The effect can be seen on many commits such as:

https://github.com/elementary/icons/commit/6e66f7b6ee65019860526045ef868e96ce27443b#diff-3d14f510306075e4a273c08dccf99071L9

Here you can see these lines are removed and re-added in reverse order, which in XML is semantically equivalent, but not for git. This is not harmful at all, just annoying.

A very simple workaround is to run inkscape twice, as this seems to cancel out the effect.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.