elementary / elementary/granite

Issues found while browsing adwaita-1-demo

Open
#931 2 comments 1 reaction 0 assignees View on GitHub
Adwaita
Dominant language
Vala
Stars
329
Forks
65
Avg merge
1d 14h
Merged PRs (30d)
31

Description

On KDE Plasma Wayland on openSUSE Slowroll, with elementary/stylesheet from git and libadwaita 1.7.6 built from source, I found a few issues. For each of these, I will try to find the appropriate issue if it's already been raised.

On each screenshot, on the left is `io.elementary.stylesheet.lime` and on the right is the libadwaita stylesheet, with accent color `#288417` applied by kde-gtk-config.

## Important pages

### Lists

![Image](https://github.com/user-attachments/assets/9037d96b-9dab-464c-bac7-a0076730679b)

* The image in the center of the radiobutton is missing. elementary/granite#930
* The spin row has unnecessary and inelegant borders. elementary/granite#933

![Image](https://github.com/user-attachments/assets/6749b22a-e21d-4fe8-b0d3-9be84fe65d91)

* The emphasis on the property row is wrong (the data should be more prominent than the title). elementary/granite#929
* The button rows are not styled at all. elementary/granite#932

### Style classes

![Image](https://github.com/user-attachments/assets/9ad4db43-e85d-4f2f-8029-804fcde1113b)

* The left-arrow and right-arrow buttons are missing. elementary/granite#928
* The backgrounds of the success, warning, and error textfields are not colored. elementary/granite#927
* The toggle groups are not styled. elementary/granite#932

![Image](https://github.com/user-attachments/assets/3c6aef21-e844-43bc-84b2-f2289893106e)

* The titles are not bold and large, and the caption is not small and greyed out. (related to elementary/stylesheet#518)
* The activatable card should look like the card button.
* The activatable row does not give feedback when pressed.

![Image](https://github.com/user-attachments/assets/5fc8a7c3-e1f6-4cd1-9cb0-8c25fae2b9f6)

* The app icons are missing their drop shadows.
* The checkboxes are missing their interiors, and the selection mode checkboxes are not larger or round. elementary/granite#930
* The toolbar is inelegant, cramped, and has visual artifacts.
* The media player icons are black rather than white (although the official stylesheet still has issues with the volume button).

Not pictured:
* The "development window" style does not make any change to the appearance of the titlebar.
* The OSD progress bar is large and clunky.

## Other pages

### Clamp

The issue is with the spin row (see Lists)

Image

### View switcher

![Image](https://github.com/user-attachments/assets/f4a1ed87-4420-4294-9b0f-f390d211473b)

The badge on the stopwatch should be highlighted, rather than the stopwatch itself.

### Tab view

![Image](https://github.com/user-attachments/assets/9f2fac35-243d-49ce-945d-ca08b634edee)

The backgrounds of some tabs are uncolored.

### Buttons

![Image](https://github.com/user-attachments/assets/f7e4a6b6-835f-47c3-b627-796880e8d632)

* The title is not bolded or large.
* The buttons are not joined together (this could probably be achieved using the linked style).
* The borderless buttons have borders (however, it could be argued that borderless buttons are not compliant with good practice or with the style of the elementaryOS stylesheet)

### Toast

![Image](https://github.com/user-attachments/assets/fc09047e-51fb-49db-8487-d500f0e06491)

* The button on the toast is light when it should be dark. (related to elementary/stylesheet#1285)

### Animations

![Image](https://github.com/user-attachments/assets/22c4440b-91c7-4a33-a781-1e4cdfca0b3d)

* The toggle group is not styled. elementary/granite#932
* The ball to be animated does not appear.

### Alert

![Image](https://github.com/user-attachments/assets/73b5dda9-7161-4aa8-aab2-5d9403a406c4)

* The alert dialog is very cramped and clunky.

### Banner

![Image](https://github.com/user-attachments/assets/757814b6-8e26-48f6-af23-a189f24df1a4)

* The banner is not styled.

### Toggle groups

![Image](https://github.com/user-attachments/assets/b426be14-990a-496f-b923-df1dce70c0ec)

* The title is not large and bold.
* The toggle groups are not styled. elementary/granite#932

### Wrap groups

![Image](https://github.com/user-attachments/assets/dacbc741-6bca-409d-83d6-c3e547aa7412)

* It may be better to make the buttons less conspicuous.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.