elementary / elementary/granite
Consider button focus rings on immediate child
Open
Needs Design
Priority: Wishlist
- Dominant language
- Vala
- Stars
- 329
- Forks
- 65
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 31
Description
## Problem
We have some issues with focus rings being outside of buttons like clipping in linked styles or when there isn’t technically any margin around the button or some issue with z axis ordering or clipping in overlays. Lots of little edge cases that make focus rings outside of the button break
## Proposal
Maybe instead, we should apply the focus style to the immediate child of the button (likely a label or icon) as a background
## Prior Art
This would look more similar to the flat button focus styles and indeed maybe we could combine a lot of the focus style code this way as well
Contributor guide
Assessment
This issue has not been assessed yet.