elementary / elementary/granite

Time format inconsistent?

Open
#254 0 comments 0 reactions 0 assignees View on GitHub
Needs Design
Dominant language
Vala
Stars
329
Forks
65
Avg merge
1d 14h
Merged PRs (30d)
31

Description

While looking at https://github.com/elementary/granite/pull/252#pullrequestreview-186485441 I noticed that time format is inconsistent between 12h and 24h format. The 24h format 's hour has a leading 0 (range 00 to 23) (`%H`) while in the 12h format single digits are preceded by a blank space (range 1 to 12) (`%l`).
![screenshot from 2018-12-19 12 01 08](https://user-images.githubusercontent.com/523210/50216337-cad4fb00-0385-11e9-92a0-fdfb3347176f.png)

12h format: `%-l:%M %p`
24h format: `%H:%M`

Shouldn't we use `%k` (`%-k:%M`) for the 24h format?
This would result in:
![screenshot from 2018-12-19 12 19 48](https://user-images.githubusercontent.com/523210/50217217-636c7a80-0388-11e9-9759-11690f92700f.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.