elementary / elementary/files

No search button

Open
#813 6 comments 3 reactions 0 assignees View on GitHub
Gtk4 Needs Design
Dominant language
Vala
Stars
365
Forks
82
Avg merge
4d 2h
Merged PRs (30d)
3

Description

I know we closed #170 with https://github.com/elementary/files/pull/763 but I think there is still room for improvement. Like finding a subtle way to include a search button.

I personnaly like the idea of adding another action icon. The tooltip for this button could be a a place to show the Ctrl + F keyboard shortcut. It could even be a place to explain that you can simply start typing to search.
![search indicator](https://user-images.githubusercontent.com/523210/47380665-4146db00-d6fe-11e8-83f7-60d4c40c1853.png)

It's a UI approach you can also see in Firefox for example:
![screenshot from 2018-12-16 14 10 18](https://user-images.githubusercontent.com/523210/50053895-5b1fff80-013c-11e9-9841-6193cd06efa2.png)

@jeremypw had a good point on this though:
> The native Gtk.Entry widget that the pathbar is based on can only show one action icon at the right so it would take some refactoring.

@donadigo added a permanent search button to he header bar in: #419, which was rejected. But I think a action icon is more subtle. It's also context dependent, like in Firefox, meaning that it could only be shown when the regular path is shown. An example in Firefox would be the Reader view button that only appears when it available.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/67592038-no-search-button?utm_campaign=plugin&utm_content=tracker%2F65602118&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F65602118&utm_medium=issues&utm_source=github).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.