elementary / elementary/docs

Code Style - Clarification needed for whitespace after closing bracket guidelines

Open
#204 0 comments 0 reactions 0 assignees View on GitHub
Confirmed
Dominant language
No language data
Stars
88
Forks
30
Avg merge
3h 28m
Merged PRs (30d)
1

Description

In the [Whitespace section](https://docs.elementary.io/develop/writing-apps/code-style#whitespace), it's unclear what should happen if a series of lines end with a closing bracket and semi-colon.

For example:

```vala
var open_in_terminal_pane_item = new Gtk.MenuItem () {
action_name = MainWindow.ACTION_PREFIX + MainWindow.ACTION_OPEN_IN_TERMINAL,
action_target = new Variant.string (file.file.get_path ())
};
```

and:

```vala
var open_in_terminal_pane_label = new Granite.AccelLabel.from_action_name (
_("Open in Terminal Pane"),
MainWindow.ACTION_PREFIX + MainWindow.ACTION_OPEN_IN_TERMINAL + "::"
);
```

Should a blank line get added after the semi-colon (`;`) in the examples above?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.