elementary / elementary/appcenter-web

Support localised screenshots

Open
#81 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
46
Forks
11
PR merge metrics
No merged PRs in 30d

Description

### Problem

If localised screenshots exist in the Flatpak metadata, they should be supported.

Currently, the first `` of the last `` in the `` section is displayed.

e.g., see https://appcenter.elementary.io/org.small_tech.comet/ where the Dutch screenshot is shown on the English page.

The relevant metadata markup is:

```


https://raw.githubusercontent.com/small-tech/comet-screenshots/main/nl/comet-basic-usage.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/tr/comet-basic-usage.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/en/comet-basic-usage.png


https://raw.githubusercontent.com/small-tech/comet-screenshots/main/nl/comet-spell-check.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/tr/comet-spell-check.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/en/comet-spell-check.png


https://raw.githubusercontent.com/small-tech/comet-screenshots/main/nl/comet-emoji.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/tr/comet-emoji.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/en/comet-emoji.png


https://raw.githubusercontent.com/small-tech/comet-screenshots/main/nl/comet-settings.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/tr/comet-settings.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/en/comet-settings.png


https://raw.githubusercontent.com/small-tech/comet-screenshots/main/nl/comet-welcome.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/tr/comet-welcome.png
https://raw.githubusercontent.com/small-tech/comet-screenshots/main/en/comet-welcome.png


```

### Proposal

## Initial workaround (easy)

Grab the first `` from the `` in the `` section if it exists. If it doesn’t take the first image from the first screenshot (not the last), in the assumption that the author would likely have put the default first even if they didn’t mark it.

## Full implementation (hard)

Actually create localised pages and serve them.

### Prior Art (Optional)

The elementary OS AppCenter itself correctly displays localised pages and screenshots.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.