elementary / elementary/appcenter-dashboard

Display correct app identifier for apps

Open
#83 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
14
Forks
5
Avg merge
23h 19m
Merged PRs (30d)
1

Description

### What Happened?

In the dashboard, my app’s identifier is listed as `com.github.small-tech.comet`.

It looks like this is calculated from the repository URI and not from the actual app identifier, which has two issues:

1. For GitHub-based app identifiers, it does not perform the character substitutions necessary to conform to DBus conventions. (In the example, above, if I was using a GitHub reverse-domain, the identifier should be `com.github.small_tech.comet` (note the underscore, not the dash) as dashes are only allowed in the last segment of the identifier.

2. For non-GitHub-based app identifiers, the identifier is entirely incorrect which might lead people to think that there is something wrong in their configuration.

### Steps to Reproduce

See above.

### Expected Behavior

The correct app identifier should be shown. This will require it to be parsed from the repository.

### OS Version

6.x (Odin)

### Software Version

Latest release (I have run all updates)

### Log Output

```shell
n/a
```

### Hardware Info

n/a

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.