element-hq / element-hq/synapse
Fix remaining uses of deprecated cmp argument in attrs decorators
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#9641](https://github.com/matrix-org/synapse/issues/9641).
---
### Description
There are a handful of places left that use the deprecated `cmp` argument on the `attr.s` decorator:
- https://github.com/matrix-org/synapse/blob/0a00b7ff14890987f09112a2ae696c61001e6cf1/synapse/events/builder.py#L38
- https://github.com/matrix-org/synapse/blob/d29b71aa50f568c3b951b95f2ea3009292b95630/tests/server.py#L472
- https://github.com/matrix-org/synapse/blob/a7a379006651ea219c2618c0a47e8f4053a9e769/synapse/types.py#L421
- https://github.com/matrix-org/synapse/blob/31b1905e13f84d839f46990d7e63bafe0917dc75/synapse/crypto/keyring.py#L65
These should be fixed.
Contributor guide
Assessment
This issue has not been assessed yet.