element-hq / element-hq/synapse

Identically named servlets cause monitoring issues

Open
#9,630 0 comments 0 reactions 0 assignees View on GitHub
A-Metrics O-Occasional S-Tolerable T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#9630](https://github.com/matrix-org/synapse/issues/9630).

---

For example:

```
synapse/rest/client/v1/room.py: JoinRoomAliasServlet(hs).register(http_server)
synapse/rest/admin/__init__.py: JoinRoomAliasServlet(hs).register(http_server)
```

The monitoring works on servlet name, so for example this graph:

![confusing](https://user-images.githubusercontent.com/1917473/111349308-ef110680-8678-11eb-9545-b78663dafc12.png)

could be for either (i don't even know what happens if you have metrics for both on the same server - perhaps they're mixed or overwritten)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.