element-hq / element-hq/synapse

Add additional debug logging to MultiWriterIdGenerator.__init__ and get_cache_dict

Open
#9,443 0 comments 0 reactions 0 assignees View on GitHub
good first issue O-Occasional S-Tolerable T-Task
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#9443](https://github.com/matrix-org/synapse/issues/9443).

---

We should add debug logging to `MultiWriterIdGenerator` similar to that in `StreamIdGenerator`, per https://github.com/matrix-org/synapse/issues/9268#issuecomment-770190320:

> If `MultiWriterIdGenerator.__init__` and `get_cache_dict` included some `logger.debug`, this would be a lot less confusing to diagonose.
>
> (I mention `MultiWriterIdGenerator` specifically, because `StreamIdGenerator.__init__` *does* write debug, via `_load_current_id`, and it is quite helpful, and the inconsistency is extra confusing.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.