element-hq / element-hq/synapse

synapse secretly uses body of `/join` request as the join event content

Open
#8,763 0 comments 0 reactions 0 assignees View on GitHub
A-Spec-Compliance
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#8763](https://github.com/matrix-org/synapse/issues/8763).

---

This is totally unspecced, but it turns out that synapse uses the body of a [`/_matrix/client/r0/join/{roomIdOrAlias}`](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-join-roomidoralias) request as the content of the join event.

Apart from being inconsistent with the spec, it also means that there is nowhere to put other options such as `server_name` (see https://github.com/matrix-org/matrix-doc/issues/2864).

(If there's a need for such a thing, it should be in a `content` key)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.