element-hq / element-hq/synapse

federation_reader processes push actions on received events

Open
#8,506 0 comments 0 reactions 0 assignees View on GitHub
A-Performance A-Workers S-Tolerable T-Enhancement z-p2
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#8506](https://github.com/matrix-org/synapse/issues/8506).

---

### Description

https://github.com/matrix-org/synapse/blob/43f2b67e4d2ce95b3b13d88e755afc7e3907e82b/synapse/handlers/federation.py#L1947

In the above, Synapse is processing push actions for all events received, which is quite expensive for the transaction processing loop. For servers that care about push, it might be more useful to punt this particular statement over to the pusher worker or one that is less on the critical path for receiving an event.

### Version information

- **Homeserver**: t2bot.io
- **Version**: 1.20.0 with minor patches

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.