element-hq / element-hq/synapse

"Requested operation has changed during the UI authentication session." shouldn't be raised if only the query string changes

Open
#7,722 0 comments 0 reactions 0 assignees View on GitHub
O-Uncommon S-Major T-Defect z-auth z-bug z-p2
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#7722](https://github.com/matrix-org/synapse/issues/7722).

---

https://github.com/matrix-org/synapse/pull/7483 changed the condition under which the "Requested operation has changed during the UI authentication session." error raised so that it's only raised if the (method, uri) changes during UIA.

This means that if e.g. I initiate a registration with `POST /register` but ends it with `POST /register?kind=user`, which is the same operation, the registration fails.

Ideally this condition should be changed to omit the query string from the uri, but we should first check if that doesn't introduce any issue (e.g. if the UIA operation is passed in the query string in some cases - which I don't think it is, but we should probably make sure of that).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.