element-hq / element-hq/synapse

Can tag non-existing room

Open
#7,638 0 comments 0 reactions 0 assignees View on GitHub
T-Enhancement Z-Help-Wanted z-p3
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#7638](https://github.com/matrix-org/synapse/issues/7638).

---

### Description
If you try to add a tag to a room that doesn't exist, synapse will happily do it and return a 200 status code.

### Steps to reproduce

- Make a Put request to `/_matrix/client/r0/user/{yourUserId}/rooms/undefined/tags/{tag}` with any json body

I would expect a 404 or similar error if you try to add a tag that doesn't exist.
### Version information

- **Homeserver**: Locally hosted

If not matrix.org:

- **Version**: 1.8.0, a quick inspection of develop makes it seems like it's still a problem

- **Install method**: git clone

- **Platform**: Centos 7

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.