element-hq / element-hq/synapse
The account validity admin route returns 200 OK even if the feature is turned off in the config
Open
O-Uncommon
S-Minor
T-Defect
z-bug
z-p2
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#6128](https://github.com/matrix-org/synapse/issues/6128).
---
There must be a `if not hs.config.account_validity.enabled: return` somewhere in one of the functions called (directly and indirectly) by the endpoint, which means that a call to [`/_synapse/admin/v1/account_validity/validity`](https://github.com/matrix-org/synapse/blob/master/docs/admin_api/account_validity.rst#renew-account) will result in the same response as if the feature was enabled.
Contributor guide
Assessment
This issue has not been assessed yet.