element-hq / element-hq/synapse

we should backoff on 40x errors

Open
#5,442 0 comments 2 reactions 0 assignees View on GitHub
T-Enhancement z-outbound-federation-meltdown z-p2
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#5442](https://github.com/matrix-org/synapse/issues/5442).

---

Currently we do not increment the per-host backoff counter on 405 (method not allowed) responses. If we get a 405, it suggests a poorly-configured destination, so we should back off.

Indeed, the only 40x codes we do back off for are 401, 429, and (sometimes) 404. If our spec actually properly defined the valid error responses, we could do much better here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.