element-hq / element-hq/synapse

Large thumbnails undershoot the requested size

Open
#5,302 0 comments 0 reactions 0 assignees View on GitHub
A-Media-Repository A-Spec-Compliance O-Occasional S-Minor T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#5302](https://github.com/matrix-org/synapse/issues/5302).

---

If you request a larger thumbnail size than the largest precalculated thumbnail, you'll get the largest precalculated thumbnail, which could significantly undershoot the requested size.

This will end up looking horrible and blurry as the client then scales up the thumbnail to the size it asked for.

In Riot/Web (as of https://github.com/matrix-org/matrix-react-sdk/pull/2439) we explicitly ask for the original image if the thumbnail exceeds 800x600, but we might do better to handle this more intelligently. Perhaps the solution is just to pregenerate even bigger thumbnails? Or default to serving the original image?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.