element-hq / element-hq/synapse

Synapse 500s when /createRoom is given with a full alias instead of the alias's localpart

Open
#5,127 0 comments 0 reactions 0 assignees View on GitHub
A-Create-Room A-Validation O-Uncommon S-Minor T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#5127](https://github.com/matrix-org/synapse/issues/5127).

---

When `/createRoom` gets queried with, e.g. `#qqqqqqqqqqqqqqqqq:matrix.org`, as the value for `room_alias_name`, instead of `qqqqqqqqqqqqqqqqq` (which is what's supposed to go there), Synapse responds with a 500 status code and logs this error:

```
synapse.api.errors.RequestSendFailed: Failed to send request: InvalidCodepoint: Codepoint U+003A at position 4 of 'org:matrix' not allowed
```

It should return, e.g. a 400 with an error message explaining the localpart is expected in the request body.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.