element-hq / element-hq/synapse
Room directory list API should record who made the room visible in the directory
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#5059](https://github.com/matrix-org/synapse/issues/5059).
---
`PUT /_matrix/client/r0/directory/list/room/{roomId}` - This doesn't record who did it
`PUT /_matrix/client/r0/directory/room/{roomAlias}` - This does, but it doesn't affect the visibility of the room in the directory
The visibility API (first endpoint) should record who did it. This isn't needed for the protocol to work, but it would be nice to have from a server admin perspective.
Contributor guide
Research direction
Start by locating the handlers for PUT /_matrix/client/r0/directory/list/room/{roomId} and PUT /_matrix/client/r0/directory/room/{roomAlias}, then compare how the latter records the actor. Done means the visibility endpoint records who changed the room's directory visibility without changing the protocol behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100