element-hq / element-hq/synapse
make prometheus_client (and possibly other metric related dependencies) optional if metrics are disabled
Open
A-Metrics
T-Enhancement
z-bug
z-p2
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#4845](https://github.com/matrix-org/synapse/issues/4845).
---
Synapse refuse to start if prometheus_client is not installed even if metrics are disabled. However if you modify `python_dependencies.py` and remove this dependency it functions well without it.
Can you make this dependency check for prometheus_client optional only if metrics are enabled?
Contributor guide
Assessment
This issue has not been assessed yet.