element-hq / element-hq/synapse

Change `initial_device_display_name` param special case?

Open
#4,638 0 comments 0 reactions 0 assignees View on GitHub
T-Enhancement
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 6h
Merged PRs (30d)
46

Description

This issue has been migrated from [#4638](https://github.com/matrix-org/synapse/issues/4638).

---

If we can bear to swap out a temporary special case for a permanent one, it would be good to override `initial_device_display_name` from the initial request params with the one from the current request instead of ignoring it in https://github.com/matrix-org/synapse/blob/master/synapse/rest/client/v2_alpha/register.py#L283

This would let us set device display names correctly when registering.

This would probably be a thing that goes in the spec too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.