element-hq / element-hq/synapse

"InviteState" in sync response has inconsistent contents

Open
#4,363 0 comments 0 reactions 0 assignees View on GitHub
A-Spec-Compliance S-Minor T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 6h
Merged PRs (30d)
46

Description

This issue has been migrated from [#4363](https://github.com/matrix-org/synapse/issues/4363).

---

### Description

The /sync client endpoint specifies the `InviteState` as a list of `StrippedState` and reads about these events that

> These state events may only have the `sender`, `type`, `state_key` and content keys present.

I see two ways to interpret this sentence (I find the "may only" ambiguous):

- either this means that these events are only allowed to contain these keys, in which case synapse is inconsistent with the spec in that it also sends non-stripped events in this list
- either this means that these events are allowed to only have these fields, in which case it is contradictory with the later definition that the contents of `InviteState` is `[StrippedState]`

### Steps to reproduce

assuming the first interpretation, #4359 contains an example JSON returned by synapse containing a mix of stripped and non-stripped events

### Version information

- **Homeserver**: my personal HS

If not matrix.org:

- **Version**: 0.34.0

- **Install method**: pip

- **Platform**: Gentoo/Linux in virtualenv

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.