element-hq / element-hq/synapse

Follow the spec regarding /client/r0/keys/changes

Open
#3,058 0 comments 0 reactions 0 assignees View on GitHub
A-Spec-Compliance good first issue S-Tolerable T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 6h
Merged PRs (30d)
46

Description

This issue has been migrated from [#3058](https://github.com/matrix-org/synapse/issues/3058).

---

### Description

Moving the discussion from the spec repo (https://github.com/matrix-org/matrix-doc/issues/1170).

A request to the endpoint will succeed even if it's missing the `to` query parameter which is marked as mandatory.

### Steps to reproduce

```bash
curl -XGET "https://matrix.org/_matrix/client/r0/keys/changes?access_token=${TOKEN}&from=${NEXT_BATCH}"
```
Replacing `TOKEN` and `NEXT_BATCH` with a valid access token and a next_batch token returned by sync, respectively.

### Expected behavior.

The endpoint should throw an error.

### Version information

Tested with synapse v0.26 & with matrix.org

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.