element-hq / element-hq/synapse

Failed email notifications are not retried

Open
#2,325 0 comments 0 reactions 0 assignees View on GitHub
A-Email-Push S-Minor T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#2325](https://github.com/matrix-org/synapse/issues/2325).

---

When there is an exception "Exception processing notifs" ([emailpusher.py line 134](https://github.com/matrix-org/synapse/blob/master/synapse/push/emailpusher.py#L134)) while sending e-mail push notifications, sending that e-mail failed.

Such e-mail push notifications are not scheduled to be re-tried later, means they are basically treated as if they succeeded. In particular, the timers to delay further e-mails are also started (see top of [emailpusher.py](https://github.com/matrix-org/synapse/blob/master/synapse/push/emailpusher.py) for the constants that define them).

This makes testing e-mail notifications very difficult, as usually no further e-mails will be sent for hours after one e-mail push notification was processed, successfully or not.

So may I propose to re-schedule unsuccessful e-mail push notifications, without starting the e-mail delaying timers.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.