element-hq / element-hq/synapse
Sliding Sync: ensure `$LAZY` membership changes from state resets get sent down
Open
A-Sync
O-Frequent
S-Minor
T-Defect
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
*Split out from https://github.com/element-hq/synapse/issues/17929#issuecomment-2511982301, as explained by @erikjohnston,*
In state reset scenarios where a membership gets reverted to a previous state, we won't have an event in the `timeline`, but will have a state change in the state deltas. Currently, the `$LAZY` membership logic only looks in the `timeline` so we will miss this kind of change.
https://github.com/element-hq/synapse/blob/8306cee06ab495fef5b29d7a8f7a6da81f8b23ea/synapse/handlers/sliding_sync/__init__.py#L1044-L1063
Contributor guide
Assessment
This issue has not been assessed yet.