element-hq / element-hq/synapse

Receiving invites from blocked users

Open
#18,479 3 comments 1 reaction 0 assignees View on GitHub
A-ignored-users A-Invite A-Push
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

### Description

Imagine the following scenario:

- user A creates room R1
- user A invites user B in room R1
- user B receives a pushed notification from user A
- user B declines and blocks user A
- user A creates room R2
- user A invites user B in room R2
- user B receives a pushed notification from user A

I guess this is wrong. user B should not receive a pushed notification from user A if user B has been blocked by user A.

The Matrix Rust SDK is trying to prevent that with https://github.com/matrix-org/matrix-rust-sdk/pull/5081, but I suspect the homeserver should also filter that out.

Is it a spec issue? Is it a homeserver missing feature? A regression? A client-side problem only? Thoughts?

### Steps to reproduce

See my previous scenario above.

### Homeserver

matrix.org

### Synapse Version

1.130.0 (b=matrix-org-hotfixes-priv,f6cffa1b29)

### Installation Method

I don't know

### Database

-

### Workers

Single process

### Platform

-

### Configuration

-

### Relevant log output

```shell
-
```

### Anything else that would be useful to know?

-

Contributor guide

Open the contributing guide

Research direction

No Synapse file, test, or entry point is named. Start by comparing the reported behavior with the Matrix specification and matrix-rust-sdk PR 5081, then trace how Synapse handles room invitations and pushed notifications. Done means identifying whether filtering belongs in the homeserver, client, or specification and documenting the expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.