element-hq / element-hq/synapse

User can add push rule to a room he isn't member of

Open
#18,333 2 comments 1 reaction 0 assignees View on GitHub
O-Uncommon S-Tolerable T-Defect Z-Needs-Spec-Clarification Z-Uncertain
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

### Description

I executed this request for a user doesn't belong to the room_id `PUT /_matrix/client/v3/pushrules/global/room/` and I got 200 OK and when I checked the db:

```sql
select * from push_rules_enable
```

I can see a record created. This shouldn't be happening.

### Steps to reproduce

PUT /_matrix/client/v3/pushrules/global/room/

### Homeserver

localhost

### Synapse Version

1.90.0

### Installation Method

Other (please mention below)

### Database

Postgres single node

### Workers

Single process

### Platform

MACOS

### Configuration

_No response_

### Relevant log output

```shell
none
```

### Anything else that would be useful to know?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.