element-hq / element-hq/synapse

ship current version of `ldap_auth_provider.py`

Open
#18,220 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

Hey.

Unfortunately I have to use *buntu for some Matrix server which I need to set up at some large research centre, for which - unlike as for Debian - no current/maintained packages are available, which is why I use the upstream packages you provide.

But it turns out, that the version of https://github.com/matrix-org/matrix-synapse-ldap3/ you ship with that, is a bit outdated.

In particular, it lacks https://github.com/matrix-org/matrix-synapse-ldap3/commit/bc90bde8f808039fa05366cb023f5c682c3d0bbc which allows a filter (e.g. to check whether a user is part of a group) to be used without at bind DN / passphrase.

Could you possibly consider to upgrade that shipped version?

I can of course just install the current one manually, but that makes it quite likely to get overwritten on the next package upgrade and me forgetting to replace it again.

And then it doesn't just fail, but simply not enforce the additional group membership filter anymore.

Thanks,
Chris.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.