element-hq / element-hq/synapse

Sliding sync: `name` field should fall back to canonical alias if there is no room name

Open
#17,697 6 comments 0 reactions 0 assignees View on GitHub
A-Sync Z-Uncertain
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

Alternatively, we could add `canonical_alias` as a separate field.

~~This is breaking the names of rooms without a `m.room.name` in EX.~~ Apparently the rust SDK doesn't use `name` field.

c.f.

https://github.com/element-hq/synapse/blob/f6c2b0ec2ea6c63f569bade481fe2a4f3c1080ae/synapse/handlers/sliding_sync/__init__.py#L1013-L1019

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.