element-hq / element-hq/synapse
Drop enable_metric flag
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#16478](https://github.com/matrix-org/synapse/issues/16478).
---
**Description:**
When configuring Synapse, having a `listener` with `type: metrics` is not enough to expose metrics. I need to also add `enable_metrics: true`.
This seems redundant and can likely be removed?
It has been [suggested earlier by reivilibre](https://github.com/matrix-org/synapse/pull/13678/files#r961535068) as well
Contributor guide
Research direction
Start by tracing Synapse's configuration handling for listeners with type: metrics and the enable_metrics setting. Determine where the two settings interact and identify the relevant configuration tests, then verify that a metrics listener exposes metrics without the redundant flag and that existing configuration behavior remains clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100