element-hq / element-hq/synapse

Incorrect notications from intentional mentions which include @room?

Open
#16,460 0 comments 0 reactions 0 assignees View on GitHub
X-Needs-Info
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#16460](https://github.com/matrix-org/synapse/issues/16460).

---

> Support for intentional mentions was apparently stabilized in https://github.com/matrix-org/synapse/pull/15520 / Synapse v1.86.0rc1, right? Yet, when I just sent a message with `@room` in a code block, which Element Web correctly translated to `m.mentions` being set but without the `room` flag, people *still* got notified.
>
> The [spec](https://spec.matrix.org/latest/client-server-api/#_m_rule_roomnotif) says that the push rule for `@room` should only be enabled if the event does not have an `m.mentions` property.

_Originally posted by @jplatte in https://github.com/matrix-org/synapse/issues/15661#issuecomment-1752915731_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.