element-hq / element-hq/synapse
Logic for auto creating auto join rooms is brittle.
Open
A-Create-Room
O-Uncommon
S-Tolerable
T-Defect
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#15813](https://github.com/matrix-org/synapse/issues/15813).
---
https://github.com/matrix-org/synapse/blob/6c749c51244df582cce8579f99a0856f79145c2e/synapse/handlers/register.py#L606-L620
Problems include:
1. If auto join is enabled *after* the first real user is created.
2. Adding bots or support users will skip creating room, but will still try and join
We should change this to create the room if the room doesn't already exist, or something like that.
Contributor guide
Assessment
This issue has not been assessed yet.