element-hq / element-hq/synapse
Clean-up server_signature_keys and server_keys_json
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#15463](https://github.com/matrix-org/synapse/issues/15463).
---
Follow-up to #15171 / #15417.
These two tables are used by the server key fetching mechanisms, https://github.com/matrix-org/synapse/issues/15171#issuecomment-1464224490 has a good summary, but the tl;dr is that `server_keys_json` seems to be a superset of `server_signature_keys` (see https://github.com/matrix-org/synapse/issues/15171#issuecomment-1464279084).
Can we remove `server_signature_keys` completely?
Contributor guide
Research direction
Start by reading the summaries in #15171 and #15417, then trace the server key fetching mechanisms and every reference to the server_signature_keys and server_keys_json tables. Done means determining whether server_signature_keys can be removed completely without breaking those mechanisms or leaving stale references.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100