element-hq / element-hq/synapse

LoggingTransaction.executemany should have a proper type hint

Open
#15,439 0 comments 0 reactions 0 assignees View on GitHub
S-Minor T-Task
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#15439](https://github.com/matrix-org/synapse/issues/15439).

---

> executemany is also presumably vulnerable to the same kind of problem?

_Originally posted by @DMRobertson in https://github.com/matrix-org/synapse/pull/15432#discussion_r1166118524_

The context here is that we committed a bug to develop that wasn't spotted by tests and wasn't spotted by linting, because the annotation for LoggingTransaction.execute wasn't strict enough. It looks like executemany has a similar problem.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.