element-hq / element-hq/synapse

"db_to_json" storage method is poorly named

Open
#14,489 0 comments 0 reactions 0 assignees View on GitHub
A-Database T-Task Z-Dev-Wishlist
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#14489](https://github.com/matrix-org/synapse/issues/14489).

---

This method converts a JSON-encoded string from a database into a Python ~~dictionary~~ object.

https://github.com/matrix-org/synapse/blob/a466164647b969efd2e85168144cd75693443c05/synapse/storage/_base.py#L146-L170

`db_to_json` feels like the wrong name for it. Perhaps `deserialise_json_from_db`?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.