element-hq / element-hq/synapse

Setting receipts from client doesn't mind syntactically-invalid event IDs (SYN-512)

Open
#1,412 0 comments 0 reactions 0 assignees View on GitHub
A-Read-Receipts A-Validation O-Uncommon S-Tolerable T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 6h
Merged PRs (30d)
46

Description

This issue has been migrated from [#1412](https://github.com/matrix-org/synapse/issues/1412).

---

From sytest:

```
Response from POST /_matrix/client/v2_alpha/rooms/!aDJeXAaoqXQuEXEOKb:localhost:8001/receipt/m.read/TODOEVENTID for user=@​_ANON_-19:localhost:8001:
HTTP/1.1 200 OK
```

I would have expected some 400-series error, as this isn't even syntactically valid as an event ID. Additionally, I'd probably expect synapse to complain if the given event ID didn't exist in the room, although there might be spec/impl. reasons to accept that anyway? I'm not sure.

(Imported from https://matrix.org/jira/browse/SYN-512)

(Reported by @leonerd)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.