element-hq / element-hq/synapse
`EventsPersistenceStorageController.persist_event` is only used by test code
Open
O-Uncommon
T-Task
Z-Cleanup
Z-Dev-Wishlist
Z-Help-Wanted
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#14039](https://github.com/matrix-org/synapse/issues/14039).
---
The following method is only used by test code (albeit extensively): https://github.com/matrix-org/synapse/blob/6caa3030835f879724c003a5b0dc66a6285451d8/synapse/storage/controllers/persist_events.py#L441-L474
Non-test code instead makes use of `EventsPersistenceStorageController.persist_events`: https://github.com/matrix-org/synapse/blob/6caa3030835f879724c003a5b0dc66a6285451d8/synapse/storage/controllers/persist_events.py#L364-L439
It seems sensible to remove `persist_event` and migrate the test code to use the plural version of the method instead.
Contributor guide
Assessment
This issue has not been assessed yet.