element-hq / element-hq/synapse

e2e upload API allows you to POST keys claiming to belong to other user's UIDs (SYN-496)

Open
#1,396 0 comments 0 reactions 0 assignees View on GitHub
A-E2EE S-Major T-Enhancement
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 6h
Merged PRs (30d)
46

Description

This issue has been migrated from [#1396](https://github.com/matrix-org/synapse/issues/1396).

---

An accidental bug in sytest:
https://github.com/matrix-org/sytest/blob/b5c03fb7764d5d64a4272d5af88bcc46fac90ecd/tests/41end-to-end-keys/01-upload-key.pl#L21

creates a user whose name is `_ANON_-6:localhost` but then manages to POST a key for a different `user_id`. I expect this ought to have failed with 403 instead.

(Imported from https://matrix.org/jira/browse/SYN-496)

(Reported by @leonerd)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.