element-hq / element-hq/synapse

Event send time graph is misleading due to including errors in the graph

Open
#13,854 0 comments 0 reactions 0 assignees View on GitHub
A-Metrics O-Occasional S-Major T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#13854](https://github.com/matrix-org/synapse/issues/13854).

---

### Description

Blocking a high traffic room meant that the event send time dropped to <10ms on average, which is not physically possible with the infrastructure I have in place - errors shouldn't count towards the "Event Send Time" graph/metric.

### Steps to reproduce

- Get lots of 403 or similar errors in sending events
- See that your send times look great on the graph now

### Homeserver

t2bot.io

### Synapse Version

1.67.0

### Installation Method

_No response_

### Platform

Ubuntu server, postgresql on a different box.

### Relevant log output

```shell
N/A
```

### Anything else that would be useful to know?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the Synapse code that produces the “Event Send Time” graph or metric, then reproduce the reported case with many 403 errors in event sending. Done means failed event sends no longer make the displayed average send time appear artificially low.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.