element-hq / element-hq/synapse
Regression in federation sender instance calls to get joined profile
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#13444](https://github.com/matrix-org/synapse/issues/13444).
---
v1.61.1 release dramatically reduced federation sender calls to the `_get_joined_profile_from_event_id` cache (see: https://github.com/matrix-org/synapse/pull/12955#issuecomment-1162800438). This seems to have returned in 1.63.1, the jump below is when we upgraded from 1.61.1 -> 1.63.1:
Contributor guide
Research direction
Start by comparing federation sender behavior between Synapse 1.61.1 and 1.63.1, focusing on calls to the `_get_joined_profile_from_event_id` cache and the referenced regression in PR #12955. Use the reported version jump and attached graph to identify the changed code path; done means explaining the call increase and adding a regression test or confirmed fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100