element-hq / element-hq/synapse

Room membership endpoints (`/join`, `/leave`, `/forget`) accept requests with malformed or no bodies

Open
#13,388 0 comments 0 reactions 0 assignees View on GitHub
A-Spec-Compliance T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#13388](https://github.com/matrix-org/synapse/issues/13388).

---

The following endpoints accept, and ignore, requests with bodies which are not valid JSON objects:

* `/_matrix/client/v3/join/{roomIdOrAlias}`
* `/_matrix/client/v3/rooms/{roomId}/join`
* `/_matrix/client/v3/rooms/{roomId}/leave`

(as well as their non-`v3` equivalents).

This is a spec violation, but it appears there are a number of clients that currently rely on it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.