element-hq / element-hq/synapse
We don't correctly clear event forward extremities when host leaves a room
Open
A-Leave
S-Minor
T-Defect
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#13348](https://github.com/matrix-org/synapse/issues/13348).
---
We try and do this here:
https://github.com/matrix-org/synapse/blob/0f971ca68e808dd16f53f5594a6b33b7bddcc9a9/synapse/storage/controllers/persist_events.py#L706
but we never read that variable, it should instead be `new_forward_extremities[room_id] = set()`.
We should also make a background update to clean out extremities for rooms we're no longer in.
Contributor guide
Assessment
This issue has not been assessed yet.