element-hq / element-hq/synapse

Faster joins: handle total failure to sync state

Open
#13,000 0 comments 1 reaction 0 assignees View on GitHub
A-Federated-Join T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#13000](https://github.com/matrix-org/synapse/issues/13000).

---

Currently, if we try every server in the room and are unable to sync state from any of them, we give up, leaving us with a room stuck in "partial state" state, and any C-S requests for state in that room timing out indefinitely.

It's not entirely clear what we should do in this case:
* Giving up isn't the right thing to do if there's a temporary network outage
* Retrying indefinitely is also not the right thing to do if we can reach all homeservers and they all claim they don't have the state we want.

https://github.com/matrix-org/synapse/blob/7c6b2204d143550d81e5bf9612c4e69fe0866b4c/synapse/handlers/federation.py#L1594-L1610

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.