element-hq / element-hq/synapse

Synapse returns unspecced property `original_event` from `/relations`

Open
#12,930 0 comments 0 reactions 0 assignees View on GitHub
A-Relations-Endpoint A-Spec-Compliance S-Tolerable T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#12930](https://github.com/matrix-org/synapse/issues/12930).

---

Synapse's implementation of `/relations` returns an unspecced property `original_event`:

https://github.com/matrix-org/synapse/blob/v1.60.0/synapse/handlers/relations.py#L166

This is not defined in the MSC so should be removed.

Contributor guide

Open the contributing guide

Research direction

Start in synapse/handlers/relations.py around line 166, where the /relations response includes original_event, and compare that response with the MSC specification linked in the issue. The work is done when the unspecced property is no longer returned by /relations.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.