element-hq / element-hq/synapse
Users not part of the backend team cannot test their Synapse PRs against matching Sytest branches
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#12754](https://github.com/matrix-org/synapse/issues/12754).
---
Sytest has a feature where by if you create a Synapse branch and a Sytest branch with the same name, your synapse PR is tested against it. However, this only works if your branch is on `matrix-org/sytest`, **not** a fork.
This leaves anyone who does not have commit access to `sytest` out in the cold regarding this feature, which means it's impossible to make CI pass if you are making changes that require fixing sytest without invoking someone on the team to create a branch on your behalf.
My recommendation would be to make Sytest a bit smarter and to ask GitHub if any PRs have been linked to the Sytest PR ~~(which I believe you can do in GitHub Actions via the API)~~ (nope, will require more thought) and check that out.
Contributor guide
Research direction
No files or tests are named. Start by locating the Sytest CI logic that matches Synapse and Sytest branch names, then review how GitHub PR links or fork branches could be discovered. Done means contributors without matrix-org/sytest access can have matching Sytest branches used to test their Synapse PRs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd, devops
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100