element-hq / element-hq/synapse
Reenable opentracing in `_handle_new_device_update_async`
Open
A-Device-List-Tracking
A-Logging
A-Tracing
S-Tolerable
T-Defect
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#12559](https://github.com/matrix-org/synapse/issues/12559).
---
In #12552 we encountered pain because of a `log_kv` call that was not correctly associated with an opentracing span.
#12554 avoided the pain by commenting out the call to `log_kv`.
It's still useful to have this data available for debugging. We should fix this so that we are able to `log_kv` once more. https://github.com/matrix-org/synapse/issues/12552#issuecomment-1109853661 describes two possible ways to do so. The error mentioned in its last paragraph has been fixed by https://github.com/matrix-org/synapse/pull/12555.
Contributor guide
Assessment
This issue has not been assessed yet.