element-hq / element-hq/synapse
Synctl crash from corrupted PID file
Open
P4
S-Tolerable
T-Defect
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#12545](https://github.com/matrix-org/synapse/issues/12545).
---
Somehow during a bad shutdown related to the server running out of memory the PID file was empty and synctl kept crashing from [this](https://github.com/matrix-org/synapse/blob/develop/synapse/_scripts/synctl.py#L105) line because `ValueError: invalid literal for int() with base 10: ''`, file empty
I fixed it by deleting the PID file You might want to handle this case better though
Contributor guide
Assessment
This issue has not been assessed yet.