element-hq / element-hq/synapse

Improve email notification context for threads

Open
#11,976 0 comments 0 reactions 0 assignees View on GitHub
A-Email-Push A-Threads T-Enhancement
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#11976](https://github.com/matrix-org/synapse/issues/11976).

---

When generating email notifications Synapse [fetches the event before and after the event which caused the notification](https://github.com/matrix-org/synapse/blob/2897fb6b4fb8bdaea0e919233d5ccaf5dea12742/synapse/push/mailer.py#L444-L465) to include context in the email.

Unfortunately this won't work well for threads where the "event" before and after aren't necessarily linear with what the person was replying to. We should fetch the event before and after that are *in the same thread*.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.