element-hq / element-hq/synapse

synctl requires `pid_file` or `worker_pid_file` to be set even when not daemonizing

Open
#11,754 0 comments 0 reactions 0 assignees View on GitHub
P4 S-Minor T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#11754](https://github.com/matrix-org/synapse/issues/11754).

---

when synctl is run with the `--no-daemonize` flag, synapse will not write a pid file. The `pid_file` and `worker_pid_file` settings in the config are therefore largely redundant; however, synctl still insists on their being present even though they are unused.

Contributor guide

Open the contributing guide

Research direction

Start by tracing synctl's handling of the --no-daemonize flag and its validation of pid_file and worker_pid_file. Confirm the current behavior, then verify that running without either setting succeeds when daemonization is disabled and that pid files remain unnecessary in this mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.